Feat: Add dimension label and percent of total to charts #3672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbarnwal
changed the title
|
It looks like we're missing a space between the dimension value and the measure value/context. Both on the dashboard overview's time series chart: And on the time dimension detail chart: |
|
When I select "no context column", I'd expect not to see the contextual label on the charts: |
ericpgreen2
reviewed
Dec 12, 2023
Comment on lines
+300
to
+304
| font-feature-settings: "case" 0, "cpsp" 0, "dlig" 0, "frac" 0, "dnom" 0, | ||
| "numr" 0, "salt" 0, "subs" 0, "sups" 0, "tnum", "zero" 0, "ss01", "ss02" 0, | ||
| "ss03" 0, "ss04" 0, "cv01" 0, "cv02" 0, "cv03" 0, "cv04" 0, "cv05" 0, | ||
| "cv06" 0, "cv07" 0, "cv08" 0, "cv09" 0, "cv10" 0, "cv11" 0, "calt", "ccmp", | ||
| "kern"; |
There was a problem hiding this comment.
Mind adding a comment to explain the motivation here?
ericpgreen2
reviewed
Dec 12, 2023
Comment on lines
12
to
13
| export let validPercTotal; | ||
| export let hovered; |
There was a problem hiding this comment.
Nit: types would be nice
ericpgreen2
reviewed
Dec 12, 2023
| const xScale = getContext(contexts.scale("x")) as ScaleStore; | ||
|
|
||
| let hovered: boolean | undefined = false; |
There was a problem hiding this comment.
Nit: given hovered is initialized to false, it doesn't look like it'll ever be undefined?
ericpgreen2
approved these changes
Dec 12, 2023
mindspank
pushed a commit
that referenced
this pull request
Dec 18, 2023
* Show labels instantly for measure charts * Add percTotal to dimension charts * Show labels only for currently hovered chart * Clean up * Prettier fix * Fix spacing, add types * Show perc in label only when context column is percent * Remove unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Summary
Issue addressed:
#3612
Details:
Chart label PRD
Steps to Verify